Skip to content

Remove unwanted warning in the python doc.#130

Merged
pbailly merged 1 commit into
release/9.0from
chore/dss-90-remove-warnings
Mar 25, 2021
Merged

Remove unwanted warning in the python doc.#130
pbailly merged 1 commit into
release/9.0from
chore/dss-90-remove-warnings

Conversation

@pbailly

@pbailly pbailly commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

The API was finished, so let's remove these warnings.

@pbailly pbailly added this to the 9.0.1 milestone Mar 25, 2021
@pbailly pbailly self-assigned this Mar 25, 2021
@sourcery-ai

sourcery-ai Bot commented Mar 25, 2021

Copy link
Copy Markdown

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 2.41 ⭐ 2.41 ⭐ 0.00
Method Length 31.79 ⭐ 31.79 ⭐ 0.00
Working memory 8.49 🙂 8.49 🙂 0.00
Quality 79.64% 79.64% 0.00%
Other metrics Before After Change
Lines 1431 1425 -6
Changed files Quality Before Quality After Quality Change
dataikuapi/dss/project.py 79.64% ⭐ 79.64% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
dataikuapi/dss/project.py DSSProject.new_recipe 17 🙂 180 😞 28 ⛔ 29.17% 😞 Try splitting into smaller methods. Extract out complex expressions
dataikuapi/dss/project.py DSSProject.duplicate 2 ⭐ 73 🙂 18 ⛔ 60.05% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.create_prediction_ml_task 2 ⭐ 75 🙂 14 😞 63.99% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_datasets 5 ⭐ 63 🙂 12 😞 65.84% 🙂 Extract out complex expressions
dataikuapi/dss/project.py DSSProject.list_streaming_endpoints 5 ⭐ 63 🙂 12 😞 65.84% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@william-lukusa william-lukusa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pbailly pbailly merged commit daa6564 into release/9.0 Mar 25, 2021
@pbailly pbailly deleted the chore/dss-90-remove-warnings branch March 25, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants